Prove packaged macOS and Windows startup before release#121
Draft
yaacovcorcos wants to merge 1 commit into
Draft
Prove packaged macOS and Windows startup before release#121yaacovcorcos wants to merge 1 commit into
yaacovcorcos wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The existing release checks could report success after BrowserWindow construction even when the renderer, preload, or packaged assets failed to load. This adds an exact-payload native startup gate for the currently shipped macOS and Windows artifacts.
Scope
This is intentionally limited to macOS and Windows startup proof. It does not include the deferred Linux AppImage/.deb, AppArmor, updater-channel, or distribution-policy work from #58.
Validation
bun run fmt:checkbun run lint(0 errors; existing repository warnings only)bun run typecheckbun run test(all 12 Turbo tasks)bun run buildbun run release:smokebun run workflow:checkgit diff --checkThe exact native payload launch runs on the corresponding macOS and Windows release builders.